remove sketchy LikelyFalse error
#645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This error would trigger on `l:0` on the basis that this is equivalent to `u:0` but always less efficient. There are no other "linting" errors like this in this library, and the C++ implementation doesn't have it, so we should drop it.
|
CI is broken because of rust-lang/rust#121684 |
|
Added a pile of commits and filed an issue on rustc to fix CI. |
apoelstra
force-pushed
the
2024-02--likely-false
branch
from
138559e to
50db03c
Compare
|
I can't properly ack because I don't feel super confident with my knowledge of the repo (talking about b87b4fb) but LGTM |
tcharding
approved these changes
Feb 28, 2024
|
cc @sanket1729 can you ACK at least the first commit here? |
|
Sure. Will do in 10 mins |
1 similar comment
|
Sure. Will do in 10 mins |
sanket1729
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This error would trigger on
l:0on the basis that this is equivalent tou:0but always less efficient. There are no other "linting" errors like this in this library, and the C++ implementation doesn't have it, so we should drop it.Fixes #633